Skip to content

CLN: remove compat.lmap #26322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2019
Merged

CLN: remove compat.lmap #26322

merged 1 commit into from
May 10, 2019

Conversation

topper-123
Copy link
Contributor

Removal of compat.lmap from the code base.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #26322 into master will decrease coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26322      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.02%     
==========================================
  Files         175      175              
  Lines       52291    52286       -5     
==========================================
- Hits        48132    48122      -10     
- Misses       4159     4164       +5
Flag Coverage Δ
#multiple 90.59% <94.44%> (-0.01%) ⬇️
#single 40.72% <44.44%> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 93.93% <ø> (-0.35%) ⬇️
pandas/core/sparse/frame.py 95.48% <100%> (-0.01%) ⬇️
pandas/plotting/_style.py 77.17% <100%> (ø) ⬆️
pandas/core/computation/expr.py 96.7% <100%> (-0.01%) ⬇️
pandas/core/frame.py 97.01% <100%> (-0.12%) ⬇️
pandas/io/html.py 92.66% <100%> (ø) ⬆️
pandas/core/sparse/scipy_sparse.py 100% <100%> (ø) ⬆️
pandas/util/testing.py 90.6% <100%> (-0.11%) ⬇️
pandas/core/internals/construction.py 95.88% <100%> (ø) ⬆️
pandas/plotting/_misc.py 38.46% <50%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d024aae...2bd2e7a. Read the comment docs.

@codecov
Copy link

codecov bot commented May 9, 2019 •
edited
Loading

Codecov Report

Merging #26322 into master will decrease coverage by <.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26322      +/-   ##
==========================================
- Coverage   92.04%   92.03%   -0.01%     
==========================================
  Files         175      175              
  Lines       52297    52292       -5     
==========================================
- Hits        48138    48129       -9     
- Misses       4159     4163       +4
Flag Coverage Δ
#multiple 90.59% <94.44%> (-0.01%) ⬇️
#single 40.73% <44.44%> (-0.16%) ⬇️
Impacted Files Coverage Δ
pandas/compat/__init__.py 93.93% <ø> (-0.35%) ⬇️
pandas/core/sparse/frame.py 95.48% <100%> (-0.01%) ⬇️
pandas/plotting/_style.py 77.17% <100%> (ø) ⬆️
pandas/core/computation/expr.py 96.7% <100%> (-0.01%) ⬇️
pandas/core/frame.py 97.01% <100%> (-0.12%) ⬇️
pandas/io/html.py 92.66% <100%> (ø) ⬆️
pandas/core/sparse/scipy_sparse.py 100% <100%> (ø) ⬆️
pandas/util/testing.py 90.7% <100%> (ø) ⬆️
pandas/core/internals/construction.py 95.88% <100%> (ø) ⬆️
pandas/plotting/_misc.py 38.46% <50%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17247ed...4417106. Read the comment docs.

@topper-123 topper-123 force-pushed the remove_compat.lmap branch from 2bd2e7a to fb67cd0 Compare May 9, 2019 07:27
@jreback
Copy link
Contributor

jreback commented May 9, 2019

can you merge master

@topper-123 topper-123 force-pushed the remove_compat.lmap branch from fb67cd0 to 4417106 Compare May 9, 2019 14:07
@topper-123
Copy link
Contributor Author

Rebased.

WillAyd
WillAyd approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 0.25.0 milestone May 10, 2019
@gfyoung gfyoung merged commit 58fd449 into pandas-dev:master May 10, 2019
@gfyoung
Copy link
Member

gfyoung commented May 10, 2019

Thanks @topper-123 !

@gfyoung gfyoung added the Clean label May 10, 2019
@topper-123 topper-123 deleted the remove_compat.lmap branch May 10, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@topper-123 @jreback @gfyoung @WillAyd